Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] NullPointException of Http Request #1059

Closed
2 tasks done
xwm1992 opened this issue Aug 1, 2022 · 0 comments
Closed
2 tasks done

[Bug] NullPointException of Http Request #1059

xwm1992 opened this issue Aug 1, 2022 · 0 comments
Assignees
@xwm1992
Labels
bug Something isn't working
Milestone
1.6.0

Comments

@xwm1992
Copy link
Contributor

xwm1992 commented Aug 1, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

Due to Objects.requireNonNull(event.getExtension(Constants.PROTOCOL_VERSION)).toString() this would cause NullPointExceptions for http request.
To solve this problem can be changed to Objects.requireNonNull(event.getSpecVersion()).toString().

How to reproduce

Use HTTP request pub/sub events.

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@xwm1992 xwm1992 added the bug Something isn't working label Aug 1, 2022
@xwm1992 xwm1992 added this to the 1.6.0 milestone Aug 1, 2022
@xwm1992 xwm1992 self-assigned this Aug 1, 2022
xwm1992 added a commit to xwm1992/EventMesh that referenced this issue Aug 1, 2022
@xwm1992
[ISSUE apache#1059] Fix NullPointException of Http Request
d82f913
@xwm1992 xwm1992 mentioned this issue Aug 1, 2022
Merged
qqeasonchen added a commit that referenced this issue Aug 1, 2022
@qqeasonchen
Merge pull request #1060 from xwm1992/trace-bug-fix
3ed2c07 
[ISSUE #1059] Fix NullPointException of Http Request
@xwm1992 xwm1992 closed this as completed Aug 2, 2022
xwm1992 added a commit that referenced this issue Aug 4, 2022
@xwm1992
[ISSUE #1059] Fix NullPointException of Http Request
81ffb3b
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
@qqeasonchen
Merge pull request #1060 from xwm1992/trace-bug-fix
4597f07 
[ISSUE #1059] Fix NullPointException of Http Request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xwm1992 xwm1992

Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@xwm1992