Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Extraction of constants [EventMeshClientUtil CloudEventProducer] #1081

Closed
1 of 2 tasks
Alonexc opened this issue Aug 3, 2022 · 2 comments · Fixed by #1226 or #1233
Closed
1 of 2 tasks

[Enhancement] Extraction of constants [EventMeshClientUtil CloudEventProducer] #1081

Alonexc opened this issue Aug 3, 2022 · 2 comments · Fixed by #1226 or #1233
Assignees
@RiemannChow
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Aug 3, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
image

Describe the solution you'd like

Located at:eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client
Extract the constants in the image, define them with "static final" and put them in this class.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Aug 3, 2022
@qqeasonchen qqeasonchen added the good first issue Issues for first-time contributors label Aug 3, 2022
@Alonexc Alonexc mentioned this issue Aug 9, 2022
Open
@kirinzhu kirinzhu mentioned this issue Aug 9, 2022
Open
22 tasks
@RiemannChow
Copy link
Contributor

I want to choose this issue as my first contribution to the EventMesh community.

@qqeasonchen
Copy link
Contributor

@RiemannChow sure ok.

@RiemannChow RiemannChow mentioned this issue Sep 5, 2022
Merged
@RiemannChow RiemannChow mentioned this issue Sep 6, 2022
Merged
qqeasonchen added a commit that referenced this issue Sep 7, 2022
@qqeasonchen
Merge pull request #1233 from RiemannChow/extraction_constants
d06066b 
[ISSUE #1081]Extraction of constants grpc、JAVA and application/cloudevents+json.
@LIU-WEI-git LIU-WEI-git mentioned this issue Sep 8, 2022
Merged
xwm1992 added a commit that referenced this issue Sep 8, 2022
@xwm1992
Merge pull request #1240 from LIU-WEI-git/0908_fix_style
f16d2e8 
[ISSUE #1081] Fix style check
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Sep 23, 2022
@qqeasonchen
Merge pull request apache#1233 from RiemannChow/extraction_constants
cca7c5d 
[ISSUE apache#1081]Extraction of constants grpc、JAVA and application/cloudevents+json.
xwm1992 added a commit to xwm1992/EventMesh that referenced this issue Sep 23, 2022
@xwm1992
Merge pull request apache#1240 from LIU-WEI-git/0908_fix_style
52fd1d1 
[ISSUE apache#1081] Fix style check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RiemannChow RiemannChow

Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
3 participants
@RiemannChow @qqeasonchen @Alonexc