Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] The PR template could be modified for auto linking issue #1102

Closed
2 tasks done
hezean opened this issue Aug 5, 2022 · 1 comment · Fixed by #1112
Closed
2 tasks done

[Enhancement] The PR template could be modified for auto linking issue #1102

hezean opened this issue Aug 5, 2022 · 1 comment · Fixed by #1112
Labels
enhancement New feature or request

Comments

@hezean
Copy link
Contributor

hezean commented Aug 5, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

Now the PR template is Fixes ISSUE #xxx, this could only mention the issue and need maintainer to manually close the issue.

GitHub provides a feature for auto linking issues, #1096 is also an example of it. Is it okay to do a little modification on the template?

Describe the solution you'd like

Fixes ISSUE #xxx -> Fixes #xxx

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@hezean hezean added the enhancement New feature or request label Aug 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group：
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@hezean hezean mentioned this issue Aug 8, 2022
Merged
qqeasonchen added a commit that referenced this issue Aug 9, 2022
@qqeasonchen
Merge pull request #1112 from HeZean/pr-template
4ac3ae4 
[ISSUE #1102] PR auto link to issue
wuyiliang1 pushed a commit to wuyiliang1/eventmesh that referenced this issue Aug 19, 2022
Merge remote-tracking branch 'origin/master' into issue_1080
a88306f 
* origin/master: (50 commits)
  [MINOR] update project licenses
  unit dependencies jar version
  fix prometheus ut test exception
  [MINOR] fix license check exception
  fix: Remove unnecessary whitespace apache#1117
  [ISSUE apache#1102] PR auto link to issue
  [MINOR] fix gradle build fail exception
  replace with Constants
  Modify some typo
  Modify some typo
  Update roadmap docs
  Extract constants of protocol-http module
  extract constants of Zipkin trace module
  [ISSUE apache#1062]translate document (workflow.md)
  [ISSUE apache#1062]translate document (workflow.md)
  [ISSUE apache#1068] translate desing-document/cloudevents to zh
  fix: EtcdRegistryServiceTest checkStyle
  remove: EtcdRegistryServiceTest nnecessary stubbings
  fix: EtcdRegistryService add shutdown executor
  fix: unit test code add RegistryException expected
  ...
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Sep 23, 2022
@hezean
[ISSUE apache#1102] PR auto link to issue
db152cb
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Sep 23, 2022
@qqeasonchen
Merge pull request apache#1112 from HeZean/pr-template
cc7385e 
[ISSUE apache#1102] PR auto link to issue
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Sep 23, 2022
Merge remote-tracking branch 'origin/master' into issue_1080
2834634 
* origin/master: (50 commits)
  [MINOR] update project licenses
  unit dependencies jar version
  fix prometheus ut test exception
  [MINOR] fix license check exception
  fix: Remove unnecessary whitespace apache#1117
  [ISSUE apache#1102] PR auto link to issue
  [MINOR] fix gradle build fail exception
  replace with Constants
  Modify some typo
  Modify some typo
  Update roadmap docs
  Extract constants of protocol-http module
  extract constants of Zipkin trace module
  [ISSUE apache#1062]translate document (workflow.md)
  [ISSUE apache#1062]translate document (workflow.md)
  [ISSUE apache#1068] translate desing-document/cloudevents to zh
  fix: EtcdRegistryServiceTest checkStyle
  remove: EtcdRegistryServiceTest nnecessary stubbings
  fix: EtcdRegistryService add shutdown executor
  fix: unit test code add RegistryException expected
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #1102] PR auto link to issue
1 participant
@hezean