Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Skywalking tracing plugin #1186

Open
1 of 2 tasks
qqeasonchen opened this issue Aug 26, 2022 · 10 comments
Open
1 of 2 tasks

[Feature] Support Skywalking tracing plugin #1186

qqeasonchen opened this issue Aug 26, 2022 · 10 comments
Assignees
Labels
feature help wanted Extra attention is needed

Comments

@qqeasonchen
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

Now eventmesh default support zipkin as tracing system, Skywalking is a widely used APM system and we can add a plugin adapter for eventmesh.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@heihei180
Copy link
Contributor

hi @qqeasonchen do you have any ideas ? if I plan to enhance three clients (TCP. HTTP, GRPC) and event mesh server, it's suitable ?

@qqeasonchen
Copy link
Contributor Author

@heihei180 you mean implement Skywalking tracing for TCP/HTTP/GRPC?

@heihei180
Copy link
Contributor

@heihei180 you mean implement SkyWalking tracing for TCP/HTTP/GRPC?

yes, i mean enhance eventMesh's three clients (where handle network io); in this way, user can view the activity of eventMesh from skyWalking UI. do you have any suggestions?

@qqeasonchen
Copy link
Contributor Author

@heihei180 sure, you can implement a trace plugin by skywalking.

@heihei180
Copy link
Contributor

@qqeasonchen implement in this project ? rather than as a plugin in skywalking-java?

@qqeasonchen
Copy link
Contributor Author

@heihei180
Copy link
Contributor

I understand your meaning. call the API of skywalking directly to monitor the status of the eventmesh server. However, another problem is that the client behavior of eventmesh cannot be monitored. but I will do this and give me some time.

@seriouszyx
Copy link
Member

@qqeasonchen It seems that this feature has not been updated recently, can you assign it to me? I will try to open some issues to split into smaller tasks.

@seriouszyx
Copy link
Member

I get that EventMesh uses OpenTelemetry to collect trace data from the server, and the tracing plugin exports the trace data to other systems (such as Zipkin and Pinpoint). However, It is hard to implement the Skywalking plugin with such ideas as there is tech block (ref).

Instead, we can support jaeger tracing plugin which can handle trace data exported by OpenTelemetry. And we can also support Skywalking metrics plugin to export EventMesh metrics data to Skywalking.

What's your opinion, @qqeasonchen ?

@qqeasonchen
Copy link
Contributor Author

@seriouszyx we can have a discuss meeting.

@Pil0tXia Pil0tXia added the help wanted Extra attention is needed label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants