Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Pravega connector writer doesn't close when unsubscribing #1347

Closed
2 tasks done
LIU-WEI-git opened this issue Sep 20, 2022 · 0 comments · Fixed by #1348
Closed
2 tasks done

[Bug] Pravega connector writer doesn't close when unsubscribing #1347

LIU-WEI-git opened this issue Sep 20, 2022 · 0 comments · Fixed by #1348
Assignees
@LIU-WEI-git
Labels
bug Something isn't working
Milestone
1.7.0

Comments

@LIU-WEI-git
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Windows

EventMesh version

master

What happened

Pravega connector writer doesn't close when unsubscribing.

How to reproduce

Read praveag connector code will find it.

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@LIU-WEI-git LIU-WEI-git added the bug Something isn't working label Sep 20, 2022
@LIU-WEI-git LIU-WEI-git mentioned this issue Sep 20, 2022
Merged
xwm1992 added a commit that referenced this issue Sep 21, 2022
@xwm1992
Merge pull request #1348 from LIU-WEI-git/fix_1347
1cc5816 
[ISSUE #1347] Close pravega writer when unsubscribing
close #1347
@xwm1992 xwm1992 added this to the 1.7.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LIU-WEI-git LIU-WEI-git

Labels
bug Something isn't working
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #1347] Close pravega writer when unsubscribing LIU-WEI-git/eventmesh
2 participants
@xwm1992 @LIU-WEI-git