Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor] #2163

Closed
2 tasks done
zhaoyansheng163 opened this issue Nov 11, 2022 · 1 comment · Fixed by #2164
Closed
2 tasks done

[Bug] This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor] #2163

zhaoyansheng163 opened this issue Nov 11, 2022 · 1 comment · Fixed by #2164
Assignees
@zhaoyansheng163
Labels
bug Something isn't working
Milestone
1.7.0

Comments

@zhaoyansheng163
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Linux

EventMesh version

master

What happened

This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor]

How to reproduce

SendSyncMessageProcessor类中第283行不要指定"UTF-8"，使用StandardCharsets.UTF_8。

Debug logs

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@zhaoyansheng163 zhaoyansheng163 added the bug Something isn't working label Nov 11, 2022
@github-actions
Copy link
Contributor

Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group：
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

@MajorHe1 MajorHe1 mentioned this issue Nov 11, 2022
Merged
MajorHe1 added a commit that referenced this issue Nov 11, 2022
@MajorHe1
Merge pull request #2164 from zhaoyansheng163/master
5ad61b9 
[ISSUE #2163]  This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor]
@xwm1992 xwm1992 added this to the 1.7.0 milestone Nov 15, 2022
@xwm1992 xwm1992 changed the title This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor] [Bug] This method needlessly uses a String literal as a Charset encoding [SendSyncMessageProcessor] Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaoyansheng163 zhaoyansheng163

Labels
bug Something isn't working
Projects
None yet
Milestone
1.7.0
2 participants
@zhaoyansheng163 @xwm1992