Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] should use time.Since instead of time.Now().Sub[consumer_manager.go] #3766

Closed
1 of 2 tasks
Alonexc opened this issue Apr 20, 2023 · 3 comments
Closed
1 of 2 tasks

[Enhancement] should use time.Since instead of time.Now().Sub[consumer_manager.go] #3766

Alonexc opened this issue Apr 20, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Issues for first-time contributors Stale

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Apr 20, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

This issue is a subproject issue of eventmesh. the subproject address is:
https://github.com/apache/eventmesh-go
image
located at:
eventmesh-go/runtime/core/protocol/grpc/consumer/consumer_manager.go line 174

Describe the solution you'd like

image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Apr 20, 2023
@Alonexc Alonexc mentioned this issue Apr 20, 2023
Open
@Alonexc Alonexc closed this as completed Apr 25, 2023
@harshithasudhakar
Copy link
Member

The PR that addresses the issue hasn't been merged yet.
apache/eventmesh-go#9

@Alonexc Alonexc reopened this May 19, 2023
@Pil0tXia Pil0tXia added the good first issue Issues for first-time contributors label Jan 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@Pil0tXia
Copy link
Member

Completed in apache/eventmesh-go#9

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Pil0tXia @Alonexc @harshithasudhakar