Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Do some code optimization.[consumer.go] #3772

Open
1 of 2 tasks
Alonexc opened this issue Apr 20, 2023 · 1 comment
Open
1 of 2 tasks

[Enhancement] Do some code optimization.[consumer.go] #3772

Alonexc opened this issue Apr 20, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors Stale

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Apr 20, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

This issue is a subproject issue of eventmesh. the subproject address is:

https://github.com/apache/eventmesh-go

image
image
located at:
eventmesh-go/plugin/connector/rocketmq/consumer.go line 105,140,173,186,219
analysis and expalanation:
186-221 lines are duplicate of plugin/connector/rocketmq/consumer.go:140-175 (dupl)

Describe the solution you'd like

Ranme _
image

Repeat code extraction as method.
image
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Apr 20, 2023
@Alonexc Alonexc changed the title [Enhancement] Do some code optimization.[rocketmq_message_reader.go] [Enhancement] Do some code optimization.[consumer.go] Apr 25, 2023
@Pil0tXia Pil0tXia added the good first issue Issues for first-time contributors label Jan 19, 2024
@github-actions github-actions bot added the Stale label Apr 22, 2024
@apache apache deleted a comment from github-actions bot Apr 23, 2024
@Pil0tXia Pil0tXia removed the Stale label Apr 23, 2024
Copy link
Contributor

It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on this matter at any time, as the community is more than willing to engage in discussions regarding the development and optimization directions of this feature.

If you feel that your issue has been resolved, please feel free to close it. Should you have any additional information to share, you are welcome to reopen this issue.

@github-actions github-actions bot added the Stale label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Issues for first-time contributors Stale
Projects
None yet
Development

No branches or pull requests

2 participants