Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Do some code optimization.[MessageEntity] #3824

Closed
1 of 2 tasks
Alonexc opened this issue Apr 27, 2023 · 1 comment · Fixed by #4792
Closed
1 of 2 tasks

[Enhancement] Do some code optimization.[MessageEntity] #3824

Alonexc opened this issue Apr 27, 2023 · 1 comment · Fixed by #4792
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented Apr 27, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-storage-plugin/eventmesh-storage-standalone/src/main/java/org/apache/eventmesh/storage/standalone/broker/model/MessageEntity.java
analysis and explanation:
a. 'MessageEntity' does not define a 'serialVersionUID' field
b. Make "message" transient or serializable.

Describe the solution you'd like

a. add serialVersionUID
b. add transient
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label Apr 27, 2023
@Alonexc Alonexc mentioned this issue Apr 27, 2023
Open
@harshithasudhakar harshithasudhakar mentioned this issue Aug 15, 2023
Closed
@Pil0tXia Pil0tXia added the good first issue Issues for first-time contributors label Jan 19, 2024
@jevinjiang
Copy link
Contributor

Can I work on this issue? kindly assign it to me!

jevinjiang added a commit to jevinjiang/eventmesh that referenced this issue Mar 18, 2024
@jevinjiang
[ISSUE apache#3824] code optimization for MessageEntity
4c75a49
jevinjiang added a commit to jevinjiang/eventmesh that referenced this issue Mar 18, 2024
@jevinjiang
[ISSUE apache#3824] code optimization for MessageEntity
246446f
@jevinjiang jevinjiang mentioned this issue Mar 18, 2024
Merged
Pil0tXia pushed a commit that referenced this issue Mar 18, 2024
@jevinjiang
[ISSUE #3824] code optimization for MessageEntity (#4792)
291d748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
3 participants
@jevinjiang @Pil0tXia @Alonexc