Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Unwritten public or protected field[HeartbeatRequestBody] #3903

Closed
1 of 2 tasks
Alonexc opened this issue May 11, 2023 · 2 comments · Fixed by #4757
Closed
1 of 2 tasks

[Enhancement] Unwritten public or protected field[HeartbeatRequestBody] #3903

Alonexc opened this issue May 11, 2023 · 2 comments · Fixed by #4757
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 11, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
image
image
located at:
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java line 70-75
analysis and explanation:
No writes were seen to this public/protected field. All reads of it will return the default value.

Describe the solution you'd like

image
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/http/consumer/EventMeshHttpConsumer.java line 120,121
image

eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java line 115,116
image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label May 11, 2023
@Alonexc Alonexc mentioned this issue May 11, 2023
Open
@Pil0tXia Pil0tXia added the good first issue Issues for first-time contributors label Jan 19, 2024
@scwlkq
Copy link
Contributor

scwlkq commented Jan 23, 2024

image
@Pil0tXia this issue has be resolved in other issue.

@Pil0tXia
Copy link
Member

@scwlkq It seems you've mistaken the object class. This issue is still valid.

image

@AaronGhebretinsae AaronGhebretinsae mentioned this issue Jan 25, 2024
Merged
mxsm pushed a commit that referenced this issue Jan 26, 2024
@AaronGhebretinsae
[ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBo…
8bb8b8f 
…dy] (#4757)

* added appropriate getters and setters for HeartbeatEntity class in HeartbeatRequestBody.java. updated EventMeshHttpConsumer.java to access aforementioned variables using correct setters. Updated HeartbeatProcessor.java to access aforementioned variables using correct getters.

* <Removed unnecessary getters and setters in eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/body/client/HeartbeatRequestBody.java >
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3903] Unwritten public or protected field [HeartbeatRequestBody] AaronGhebretinsae/eventmesh
3 participants
@Pil0tXia @scwlkq @Alonexc