Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method needlessly defines parameter with concrete classes[EventMeshUtil] #3906

Closed
1 of 2 tasks
Alonexc opened this issue May 11, 2023 · 2 comments · Fixed by #4527
Closed
1 of 2 tasks

[Enhancement] Method needlessly defines parameter with concrete classes[EventMeshUtil] #3906

Alonexc opened this issue May 11, 2023 · 2 comments · Fixed by #4527
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 11, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/EventMeshUtil.java line 247
analysis and explanation:
This method uses concrete classes for parameters when only methods defined in an implemented interface or superclass are used. Consider increasing the abstraction of the interface to make low impact changes easier to accomplish in the future.

Describe the solution you'd like

Use Collection instead of List.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label May 11, 2023
@Alonexc Alonexc mentioned this issue May 11, 2023
Open
@tooo-bad
Copy link
Contributor

Does this problem still need to be solved? I want to contribute to it.

@Pil0tXia
Copy link
Member

@tooo-bad I recommend you to submit PRs one by one to get familiar with the collaboration of community.

@tooo-bad tooo-bad mentioned this issue Nov 1, 2023
Merged
@mxsm mxsm added the good first issue Issues for first-time contributors label Nov 1, 2023
@mxsm mxsm closed this as completed in #4527 Nov 1, 2023
mxsm pushed a commit that referenced this issue Nov 1, 2023
@tooo-bad
[ISSUE #3906] Do some code optimization.[EventMeshUtil] (#4527)
bdacd23 
* fix issue 3825

* return

* fix_patch_issue3906
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3906] Do some code optimization.[EventMeshUtil] tooo-bad/eventmesh
4 participants
@mxsm @Pil0tXia @Alonexc @tooo-bad