Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Method needlessly defines parameter with concrete classes[HttpTinyClient] #3907

Closed
1 of 2 tasks
Alonexc opened this issue May 11, 2023 · 0 comments · Fixed by #4004
Closed
1 of 2 tasks

[Enhancement] Method needlessly defines parameter with concrete classes[HttpTinyClient] #3907

Alonexc opened this issue May 11, 2023 · 0 comments · Fixed by #4004
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 11, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/HttpTinyClient.java line 64,81
analysis and explanation:
This method uses concrete classes for parameters when only methods defined in an implemented interface or superclass are used. Consider increasing the abstraction of the interface to make low impact changes easier to accomplish in the future.

Describe the solution you'd like

Use Collection instead of List.

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
2 participants
@xwm1992 @Alonexc