Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Anonymous new ChannelFutureListener() can be replaced with lambda #3909

Closed
1 of 2 tasks
Alonexc opened this issue May 11, 2023 · 0 comments · Fixed by #3923
Closed
1 of 2 tasks

[Enhancement] Anonymous new ChannelFutureListener() can be replaced with lambda #3909

Alonexc opened this issue May 11, 2023 · 0 comments · Fixed by #3923
Labels
enhancement New feature or request good first issue Issues for first-time contributors

Comments

@Alonexc
Copy link
Contributor

Alonexc commented May 11, 2023

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

image
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/task/MessageTransferTask.java line 137

Describe the solution you'd like

image

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@Alonexc Alonexc added the enhancement New feature or request label May 11, 2023
@Alonexc Alonexc mentioned this issue May 11, 2023
Open
PickBas added a commit to PickBas/incubator-eventmesh that referenced this issue May 13, 2023
@PickBas
[ISSUE apache#3909] Replaced anonymous new ChannelFutureListener() wi…
15a0dbf 
…th lambda
@PickBas PickBas mentioned this issue May 13, 2023
Merged
@xwm1992 xwm1992 added the good first issue Issues for first-time contributors label May 29, 2023
xwm1992 pushed a commit that referenced this issue May 31, 2023
@PickBas
[ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lam…
6fbfd7a 
…bda (#3923)

* [ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda

* Fixed checkstyle for source-connector-rocketmq

* Fixed checkstyle for eventmesh-storage-rocketmq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issues for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #3909] Replaced anonymous new ChannelFutureListener() with lambda PickBas/incubator-eventmesh
2 participants
@xwm1992 @Alonexc