Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Feishu sink connector #4420

Closed
1 of 3 tasks
qqeasonchen opened this issue Aug 30, 2023 · 10 comments · Fixed by #4522
Closed
1 of 3 tasks

[Feature] Add Feishu sink connector #4420

qqeasonchen opened this issue Aug 30, 2023 · 10 comments · Fixed by #4522
Assignees
Labels

Comments

@qqeasonchen
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

Add Feishu sink connector

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@SunnyBoy-WYH
Copy link
Contributor

SunnyBoy-WYH commented Oct 17, 2023

hi,as we know ,feishu is a chat tool , this issue expected send msg card for notification or feishu table?

@xwm1992
Copy link
Contributor

xwm1992 commented Oct 17, 2023

hi,as we know ,feishu is a chat tool , this issue expected send msg card for notification or feishu table?

The Feishu sink connector expected send msg to Feishu Bot, which you can get the webhook config of Feishu Bot and using in the sink connector.

@SunnyBoy-WYH
Copy link
Contributor

hi,as we know ,feishu is a chat tool , this issue expected send msg card for notification or feishu table?

The Feishu sink connector expected send msg to Feishu Bot, which you can get the webhook config of Feishu Bot and using in the sink connector.

i see the feishu openapi doc, after send msg to bot,bot will send msg to somebody or group? it need user's id ,where we expected config the user's id(tell the bot we expected send to whom)?

@Pil0tXia
Copy link
Member

@SunnyBoy-WYH Yes, the message destination is required if necessary.

@SunnyBoy-WYH
Copy link
Contributor

if no required ddl, can you assign it to me temporarily?

@Pil0tXia
Copy link
Member

You may submit a PR.

@SunnyBoy-WYH
Copy link
Contributor

SunnyBoy-WYH commented Oct 18, 2023

we need request to feishu open api, should we use HTTPClientPool tool in eventmesh-runtime module? thanks for your advice~

or we can use feishu sdk? https://github.com/larksuite/oapi-sdk-java/blob/v2_main/README.zh.md,but seems not support send msg:
image

@Pil0tXia
Copy link
Member

@SunnyBoy-WYH SDK and OpenAPI are both OK, however it is not recommended to add code to runtime that only a certain connector will use.

@SunnyBoy-WYH
Copy link
Contributor

@SunnyBoy-WYH SDK and OpenAPI are both OK, however it is not recommended to add code to runtime that only a certain connector will use.

ok, maybe we can use okhttp? and how can we connectRecord transfer to feishu msg? just let connectRecord.getData() as feishu message ?

@xwm1992
Copy link
Contributor

xwm1992 commented Oct 23, 2023

@SunnyBoy-WYH SDK and OpenAPI are both OK, however it is not recommended to add code to runtime that only a certain connector will use.

ok, maybe we can use okhttp? and how can we connectRecord transfer to feishu msg? just let connectRecord.getData() as feishu message ?

yes, you can treat the data as feishu message.

SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Oct 30, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 13, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 13, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 14, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 16, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 18, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 18, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 18, 2023
SunnyBoy-WYH added a commit to SunnyBoy-WYH/incubator-eventmesh that referenced this issue Nov 18, 2023
xwm1992 pushed a commit that referenced this issue Nov 19, 2023
* [ISSUE #4420] Add Feishu Sink connector

* [ISSUE #4420] Add Feishu Sink connector

* [ISSUE #4420] Add Feishu Sink connector

* [ISSUE #4420] Add Feishu Sink connector

* [ISSUE #4420] Add Feishu Sink connector,code style

* [ISSUE #4420] Add Feishu Sink connector,check style

* [ISSUE #4420] Add Feishu Sink connector,mock test

* [ISSUE #4420] Add Feishu Sink connector,mock test

* [ISSUE #4420] Add Feishu Sink connector,mock test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants