Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] EventMeshTCPServer set unknown channel options #448

Closed
liutaohua opened this issue Jul 19, 2021 · 4 comments
Closed

[Bug] EventMeshTCPServer set unknown channel options #448

liutaohua opened this issue Jul 19, 2021 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@liutaohua
Copy link
Contributor

liutaohua commented Jul 19, 2021

We can see these WARN logs during startup:

2021-07-19 16:22:47,008 WARN  [eventMesh-tcp-server] ServerBootstrap(AbstractBootstrap.java:452) - Unknown channel option 'TCP_NODELAY' for channel '[id: 0xbcef744f]'
2021-07-19 16:22:47,009 WARN  [eventMesh-tcp-server] ServerBootstrap(AbstractBootstrap.java:452) - Unknown channel option 'SO_KEEPALIVE' for channel '[id: 0xbcef744f]'
2021-07-19 16:22:47,010 WARN  [eventMesh-tcp-server] ServerBootstrap(AbstractBootstrap.java:452) - Unknown channel option 'SO_TIMEOUT' for channel '[id: 0xbcef744f]'
2021-07-19 16:22:47,010 WARN  [eventMesh-tcp-server] ServerBootstrap(AbstractBootstrap.java:452) - Unknown channel option 'SO_LINGER' for channel '[id: 0xbcef744f]'

These parameters need to be set to childOption. eg.:

bootstrap.group(bossGroup, ioGroup)
                    .channel(NioServerSocketChannel.class)
//                    .option(ChannelOption.TCP_NODELAY, true)
                    .childOption(ChannelOption.TCP_NODELAY, true)
@liutaohua liutaohua added the bug Something isn't working label Jul 19, 2021
@lrhkobe
Copy link
Contributor

lrhkobe commented Jul 20, 2021

Yes,you are right. Maybe you can submit a pr to fix it.

@liutaohua
Copy link
Contributor Author

Yes,you are right. Maybe you can submit a pr to fix it.

OK. I'll submit it when I'm free from work

@lrhkobe
Copy link
Contributor

lrhkobe commented Jul 20, 2021

As to the 4 channel options , do you think it is necessary to change the default value in EventMesh?

@liutaohua
Copy link
Contributor Author

As to the 4 channel options , do you think it is necessary to change the default value in EventMesh?

Frankly, I don't have a systematic understanding of logic. I can't give an accurate reply to what values these parameters are recommended to users. Or what ideas can you put forward?

If I perform better in the stress test, I will remember to give back these values.

@xwm1992 xwm1992 added this to the 1.3.0 milestone Dec 16, 2021
@xwm1992 xwm1992 changed the title EventMeshTCPServer set unknown channel options [Bug] EventMeshTCPServer set unknown channel options Dec 16, 2021
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants