Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #700] Dashboard: Display Eventmesh Metrics #1135

Merged
merged 12 commits into from Aug 10, 2022

Conversation

RSTdefg
Copy link
Member

@RSTdefg RSTdefg commented Aug 9, 2022

Motivation

Display Eventmesh HTTP and TCP metrics inside dashboard

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1135 (228eb4f) into dashboard (9f7283f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##             dashboard   #1135      +/-   ##
==============================================
- Coverage         9.26%   9.25%   -0.01%     
- Complexity         583     587       +4     
==============================================
  Files              361     363       +2     
  Lines            22944   23064     +120     
  Branches          2516    2518       +2     
==============================================
+ Hits              2125    2134       +9     
- Misses           20627   20737     +110     
- Partials           192     193       +1     
Impacted Files Coverage Δ
...ime/admin/controller/EventMeshAdminController.java 0.00% <0.00%> (ø)
...ventmesh/runtime/admin/handler/MetricsHandler.java 0.00% <0.00%> (ø)
...esh/runtime/admin/response/GetMetricsResponse.java 0.00% <0.00%> (ø)
...mesh/connector/standalone/broker/MessageQueue.java 40.25% <0.00%> (+7.79%) ⬆️
...tandalone/broker/task/HistoryMessageClearTask.java 47.05% <0.00%> (+17.64%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@xiaoyang-sde xiaoyang-sde changed the title [Issue #700]Dashboard: Display Eventmesh Metrics [Issue #700] Dashboard: Display Eventmesh Metrics Aug 10, 2022
@xiaoyang-sde xiaoyang-sde self-requested a review August 10, 2022 01:50
Copy link
Member

@xiaoyang-sde xiaoyang-sde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run lint to lint the TypeScript files. I guess we could extract this component into a seperate page?

@xiaoyang-sde xiaoyang-sde merged commit c199183 into apache:dashboard Aug 10, 2022
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants