Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1090] Support for managing EventMesh events using AsyncAPI #1189

Merged
merged 2 commits into from Aug 30, 2022
Merged

[ISSUE #1090] Support for managing EventMesh events using AsyncAPI #1189

merged 2 commits into from Aug 30, 2022

Conversation

walterlife
Copy link
Contributor

Fixes #1090

Motivation

add eventmesh-catalog module,support for managing EventMesh events using AsyncAPI

Modifications

add eventmesh-catalog-go module。

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1189 (a6037f8) into eventmesh-workflow-go (5ae52c8) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             eventmesh-workflow-go   #1189   +/-   ##
=======================================================
  Coverage                     9.95%   9.95%           
  Complexity                     640     640           
=======================================================
  Files                          382     382           
  Lines                        23640   23640           
  Branches                      2619    2619           
=======================================================
  Hits                          2353    2353           
  Misses                       21067   21067           
  Partials                       220     220           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walleliu1016
Copy link
Contributor

walleliu1016 commented Aug 29, 2022

I have no problem with the PR, but it would be better to add some more test cases for each go file.
The main function is empty
@walterlife

Copy link
Contributor

@qqeasonchen qqeasonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qqeasonchen qqeasonchen merged commit ad69f86 into apache:eventmesh-workflow-go Aug 30, 2022
@walterlife
Copy link
Contributor Author

walterlife commented Aug 31, 2022

I have no problem with the PR, but it would be better to add some more test cases for each go file. The main function is empty @walterlife

Yes, I will add UT under after the overall core code is completed

xwm1992 pushed a commit to xwm1992/EventMesh that referenced this pull request Sep 23, 2022
[ISSUE apache#1090] Support for managing EventMesh events using AsyncAPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants