Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1092,#1091] java sdk add workflow/catalog client #1232

Closed
wants to merge 6 commits into from
Closed

[ISSUE #1092,#1091] java sdk add workflow/catalog client #1232

wants to merge 6 commits into from

Conversation

walterlife
Copy link
Contributor

@walterlife walterlife commented Sep 6, 2022

Fixes #1091 #1092 .

Motivation

Applications can access the EventMesh Workflow/AysncAPI capabilities through the EventMesh SDK to fill the event governance capabilities

Modifications

  1. add workflow grpc client
  2. add catalog grpc client
  3. add nacos naming selector
  4. add workflow/catalog protocol into eventmesh-common module

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #1232 (c53d236) into master (5101b39) will decrease coverage by 0.85%.
The diff coverage is 0.00%.

❗ Current head c53d236 differs from pull request most recent head e9abfca. Consider uploading reports for the commit e9abfca to get more accurate results

@@             Coverage Diff              @@
##             master    #1232      +/-   ##
============================================
- Coverage     11.19%   10.33%   -0.86%     
  Complexity      758      758              
============================================
  Files           421      439      +18     
  Lines         24580    26620    +2040     
  Branches       2683     2925     +242     
============================================
  Hits           2752     2752              
- Misses        21565    23605    +2040     
  Partials        263      263              
Impacted Files Coverage Δ
...in/java/org/apache/eventmesh/common/Constants.java 85.71% <ø> (ø)
...sh/common/protocol/catalog/protos/CatalogGrpc.java 0.00% <0.00%> (ø)
.../protocol/catalog/protos/EventmeshCatalogGrpc.java 0.00% <0.00%> (ø)
...mesh/common/protocol/catalog/protos/Operation.java 0.00% <0.00%> (ø)
...rotocol/catalog/protos/QueryOperationsRequest.java 0.00% <0.00%> (ø)
...otocol/catalog/protos/QueryOperationsResponse.java 0.00% <0.00%> (ø)
...ommon/protocol/catalog/protos/RegistryRequest.java 0.00% <0.00%> (ø)
...mmon/protocol/catalog/protos/RegistryResponse.java 0.00% <0.00%> (ø)
...rotocol/workflow/protos/EventmeshWorkflowGrpc.java 0.00% <0.00%> (ø)
...ommon/protocol/workflow/protos/ExecuteRequest.java 0.00% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qqeasonchen
Copy link
Contributor

@walterlife hi,this pr may be too big to review, can you split it into several small prs?

@walterlife
Copy link
Contributor Author

@walterlife hi,this pr may be too big to review, can you split it into several small prs?

ok, plan to split four, protocol, workflow-client, catalog-client, nacos-selector

@walterlife walterlife closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Java SDK adds EventMesh Workflow Client
2 participants