Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1350] Fix WebHookProcessorTest test error #1351

Merged
merged 1 commit into from Sep 21, 2022

Conversation

githublaohu
Copy link
Contributor

Fixes #1350 .

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

Modifications

Describe the modifications you've done.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1351 (13567a0) into master (84e9d5a) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #1351      +/-   ##
============================================
- Coverage     10.44%   10.44%   -0.01%     
  Complexity      764      764              
============================================
  Files           435      435              
  Lines         26552    26553       +1     
  Branches       2924     2924              
============================================
  Hits           2773     2773              
- Misses        23519    23520       +1     
  Partials        260      260              
Impacted Files Coverage Δ
.../eventmesh/common/config/ConfigurationWrapper.java 38.18% <66.66%> (-0.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xwm1992 xwm1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xwm1992 xwm1992 merged commit c614885 into apache:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix WebHookProcessorTest test error
2 participants