[ISSUE #3707]fix thread leak with rocketmq consumer start and shutdown frequently #3708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3707.
Motivation
when using rocketmq as eventmesh storage,and consumer groups are frequently started and shutdown.
The number of threads in the process continues to increase,and eventually led to Full GC
Modifications
In the rocketmq eventmesh storage, we overwrite the ConsumeMessageConcurrentlyService.java of rocketmq
but in the shutdown(long) method, we didn't do anything, this led to some consumer threads are not recycled when consumer was shutdown
the shutdown(long) method in ConsumeMessageConcurrentlyService.java
where the ConsumeMessageConcurrentlyService.shutdown(long) method was invoked
Therefore, my modification is to supplement the logic of shutdown (long) .
Documentation