[ISSUE #3463] Do some code optimization[EventmeshRebalanceImpl] #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alonexc
reviewed
Apr 21, 2023
| map.put(key, value); | ||
| } | ||
| }); | ||
| textMapPropagator.inject(context, map, (carrier, key, value) -> map.put(key, value)); |
There was a problem hiding this comment.
Repeat fix here: pr #3786.
One issue corresponds to one pr.
xwm1992
approved these changes
May 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #3788 +/- ##
============================================
- Coverage 13.82% 13.81% -0.01%
+ Complexity 1292 1291 -1
============================================
Files 571 571
Lines 29089 29089
Branches 2841 2841
============================================
- Hits 4021 4019 -2
- Misses 24696 24697 +1
- Partials 372 373 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3463 .
Motivation
Code optimization on EventmeshRebalanceImpl
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Replace null with Collections.emptyMap()
Documentation