Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3837]Change to private and add the transient modifier[HttpCommand] #3841

Merged
merged 5 commits into from
May 15, 2023

Conversation

harshithasudhakar
Copy link
Member

Fixes #3837

Modifications

Changed to private and add the transient modifier at lines 60,61

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Changed to private and add the transient modifier at lines 60,61
@Alonexc
Copy link
Contributor

Alonexc commented Apr 28, 2023

These can be changed to private modifications.Use getter and setter for external fetching and setting.
image

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #3841 (0d1570d) into master (91aab4d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 0d1570d differs from pull request most recent head 6a3dc8e. Consider uploading reports for the commit 6a3dc8e to get more accurate results

@@             Coverage Diff              @@
##             master    #3841      +/-   ##
============================================
+ Coverage     13.77%   13.79%   +0.02%     
- Complexity     1290     1292       +2     
============================================
  Files           571      571              
  Lines         29129    29140      +11     
  Branches       2837     2849      +12     
============================================
+ Hits           4012     4020       +8     
- Misses        24745    24747       +2     
- Partials        372      373       +1     
Impacted Files Coverage Δ
...he/eventmesh/common/protocol/http/HttpCommand.java 60.43% <100.00%> (+1.81%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@harshithasudhakar
Copy link
Member Author

These can be changed to private modifications.Use getter and setter for external fetching and setting. image

I have modified to externally fetch and set now.

@xwm1992 xwm1992 merged commit 472d598 into apache:master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Change to private and add the transient modifier[HttpCommand]
3 participants