-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3837]Change to private and add the transient modifier[HttpCommand] #3841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to private and add the transient modifier at lines 60,61
Codecov Report
@@ Coverage Diff @@
## master #3841 +/- ##
============================================
+ Coverage 13.77% 13.79% +0.02%
- Complexity 1290 1292 +2
============================================
Files 571 571
Lines 29129 29140 +11
Branches 2837 2849 +12
============================================
+ Hits 4012 4020 +8
- Misses 24745 24747 +2
- Partials 372 373 +1
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xwm1992
requested changes
May 5, 2023
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/HttpCommand.java
Outdated
Show resolved
Hide resolved
xwm1992
requested changes
May 9, 2023
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/HttpCommand.java
Outdated
Show resolved
Hide resolved
eventmesh-common/src/main/java/org/apache/eventmesh/common/protocol/http/HttpCommand.java
Outdated
Show resolved
Hide resolved
xwm1992
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3837
Modifications
Changed to private and add the transient modifier at lines 60,61
Documentation