Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3858]The interface RegistryService can design some default methods. #3859

Merged
merged 5 commits into from
May 15, 2023

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 2, 2023

Fixes #3858.

Motivation

See Enhancement Request in issue for detail.

Modifications

See Describe the solution you'd like in issue for detail.

Documentation

  • Does this pull request introduce a new feature? no

@pandaapo
Copy link
Member Author

pandaapo commented May 2, 2023

  1. Note 1(EtcdRegistryService):

I should but do not yet delete the method findEventMeshClientDistributionData() and findEventMeshServicePubTopicInfos() in EtcdRegistryService. Because there has been an issue #3505 to modify(not delete) these places, and its pr is still waiting for merging for 3 weeks. If I delete these two methods before, it maybe results in conflict.

So I choose to wait for that pr to be processed, and then delete method findEventMeshClientDistributionData() and findEventMeshServicePubTopicInfos() in a new pr or this pr.


  1. Situation above resolved: Because the pr linked issue [Enhancement] Do some code optimization[EtcdRegistryService] #3505 has been merged. In this pr, I can delete the method findEventMeshClientDistributionData() and findEventMeshServicePubTopicInfos() in EtcdRegistryService.

@pandaapo
Copy link
Member Author

pandaapo commented May 2, 2023

  1. Note 2(ZookeeperRegistryService):

Although issue #3833 wants to modify(not delete) findEventMeshClientDistributionData() and findEventMeshServicePubTopicInfos() in ZookeeperRegistryService, I delete them immediately here to satisfy issue #3858 since there is no pr linked to #3833 for now.

If someone submit a pr linked issue #3833 and is merged before this pr in the future, conflicts may happen. I should pay attention to that situation.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3859 (a543043) into master (638edbe) will decrease coverage by 0.13%.
The diff coverage is 28.57%.

❗ Current head a543043 differs from pull request most recent head cb6a01e. Consider uploading reports for the commit cb6a01e to get more accurate results

@@             Coverage Diff              @@
##             master    #3859      +/-   ##
============================================
- Coverage     13.93%   13.80%   -0.13%     
+ Complexity     1291     1290       -1     
============================================
  Files           570      571       +1     
  Lines         28842    29072     +230     
  Branches       2807     2845      +38     
============================================
- Hits           4019     4014       -5     
- Misses        24450    24682     +232     
- Partials        373      376       +3     
Impacted Files Coverage Δ
...tmesh/registry/etcd/service/EtcdCustomService.java 0.00% <0.00%> (ø)
...h/registry/nacos/service/NacosRegistryService.java 43.75% <21.42%> (+7.18%) ⬆️
...registry/consul/service/ConsulRegistryService.java 41.79% <33.33%> (+0.61%) ⬆️
...esh/registry/etcd/service/EtcdRegistryService.java 20.00% <50.00%> (+0.31%) ⬆️
...ry/zookeeper/service/ZookeeperRegistryService.java 76.15% <60.00%> (+0.34%) ⬆️

... and 44 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit 33cda29 into apache:master May 15, 2023
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] The interface RegistryService can design some default methods.
2 participants