Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3863]Rename EventmeshRebalanceImpl class name and EventmeshRebalanceImpl#caculateRedirectNum method name #3864

Merged
merged 2 commits into from
May 15, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented May 3, 2023

Fixes #3863

Motivation

Method name misspelled.

Modifications

  • Rename EventmeshRebalanceImpl class name and EventmeshRebalanceImpl#caculateRedirectNum method name

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Alonexc
Alonexc previously approved these changes May 4, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3864 (d247042) into master (3edfe92) will not change coverage.
The diff coverage is 0.00%.

❗ Current head d247042 differs from pull request most recent head b232831. Consider uploading reports for the commit b232831 to get more accurate results

@@            Coverage Diff            @@
##             master    #3864   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28842    28842           
  Branches       2807     2807           
=========================================
  Hits           4019     4019           
  Misses        24450    24450           
  Partials        373      373           
Impacted Files Coverage Δ
...che/eventmesh/runtime/boot/EventMeshTCPServer.java 0.57% <ø> (ø)
...l/tcp/client/rebalance/EventMeshRebalanceImpl.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mroccyen
Copy link
Contributor

mroccyen commented May 9, 2023

@mxsm Please fixes conflict

@xwm1992 xwm1992 merged commit c83feb5 into apache:master May 15, 2023
7 checks passed
@mxsm mxsm deleted the eventmesh-3863 branch May 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants