Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3874] Add a load balance strategy: source ip hash #3875

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pandaapo
Copy link
Member

@pandaapo pandaapo commented May 7, 2023

Fixes #3874.

Motivation

Add a load balance strategy: source ip hash. Make the same client machine always arrive at the same server.

Modifications

Add a new LoadBalanceSelector for implementing source ip hash algorithm.
Add unit test for new LoadBalanceSelector.

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3875 (9e60028) into master (0ce8d57) will decrease coverage by 0.23%.
The diff coverage is 64.44%.

❗ Current head 9e60028 differs from pull request most recent head 78c6b51. Consider uploading reports for the commit 78c6b51 to get more accurate results

@@             Coverage Diff              @@
##             master    #3875      +/-   ##
============================================
- Coverage     14.24%   14.01%   -0.23%     
+ Complexity     1320     1303      -17     
============================================
  Files           579      572       -7     
  Lines         28967    28891      -76     
  Branches       2802     2818      +16     
============================================
- Hits           4125     4049      -76     
- Misses        24450    24469      +19     
+ Partials        392      373      -19     
Impacted Files Coverage Δ
...entmesh/client/http/util/HttpLoadBalanceUtils.java 53.57% <0.00%> (ø)
...ache/eventmesh/common/utils/CommonStringUtils.java 83.33% <83.33%> (ø)
...n/loadbalance/SourceIPHashLoadBalanceSelector.java 88.00% <88.00%> (ø)
.../eventmesh/common/loadbalance/LoadBalanceType.java 81.81% <100.00%> (+1.81%) ⬆️

... and 142 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Apr 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 64.44444% with 16 lines in your changes missing coverage. Please review.

Project coverage is 14.01%. Comparing base (0ce8d57) to head (9e60028).
Report is 533 commits behind head on master.

Current head 9e60028 differs from pull request most recent head 78c6b51

Please upload reports for the commit 78c6b51 to get more accurate results.

Files Patch % Lines
...entmesh/client/http/util/HttpLoadBalanceUtils.java 0.00% 12 Missing ⚠️
...n/loadbalance/SourceIPHashLoadBalanceSelector.java 88.00% 2 Missing and 1 partial ⚠️
...ache/eventmesh/common/utils/CommonStringUtils.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3875      +/-   ##
============================================
- Coverage     14.24%   14.01%   -0.23%     
+ Complexity     1320     1303      -17     
============================================
  Files           579      572       -7     
  Lines         28967    28891      -76     
  Branches       2802     2818      +16     
============================================
- Hits           4125     4049      -76     
- Misses        24450    24469      +19     
+ Partials        392      373      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please resolve conflicts.

@Pil0tXia Pil0tXia changed the title [ISSUE #3874]Add a load balance strategy: source ip hash [ISSUE #3874] Add a load balance strategy: source ip hash Apr 23, 2024
@github-actions github-actions bot removed the Stale label Apr 23, 2024
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a load balance strategy: source ip hash
3 participants