Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3472]Do some code optimization[HttpProtocolAdaptor] #3883

Merged
merged 2 commits into from
Nov 12, 2023

Conversation

harshithasudhakar
Copy link
Member

@harshithasudhakar harshithasudhakar commented May 7, 2023

Fixes #3472

Modifications

imported java.util.Collections
returns Collections.emptyList() at line 81.

  1. Used Objects.requireNonNull() at line 103

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

1. 
imported `java.util.Collections`
returns `Collections.emptyList()` at line 81.

2. Used `Objects.requireNonNull()` at line 103
@harshithasudhakar harshithasudhakar changed the title [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor [ISSUE #3472]Do some code optimization[HttpProtocolAdaptor] May 7, 2023
Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #3883 (2cc7864) into master (e1e9aca) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 2cc7864 differs from pull request most recent head 424a9af. Consider uploading reports for the commit 424a9af to get more accurate results

@@            Coverage Diff            @@
##             master    #3883   +/-   ##
=========================================
  Coverage     13.93%   13.93%           
  Complexity     1291     1291           
=========================================
  Files           570      570           
  Lines         28847    28847           
  Branches       2811     2811           
=========================================
  Hits           4019     4019           
  Misses        24455    24455           
  Partials        373      373           
Impacted Files Coverage Δ
...e/eventmesh/protocol/http/HttpProtocolAdaptor.java 5.26% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pandaapo pandaapo merged commit 9cb1704 into apache:master Nov 12, 2023
@harshithasudhakar harshithasudhakar deleted the patch-32 branch November 13, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Do some code optimization[HttpProtocolAdaptor]
4 participants