[ISSUE #3010]Method manually handles closing an auto-closeable resource [RegistryHandler] #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxsm
reviewed
May 9, 2023
Comment on lines
96
to
104
| httpExchange.sendResponseHeaders( | ||
| 200, | ||
| Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET).length | ||
| ); | ||
| try (OutputStream out = httpExchange.getResponseBody()) { | ||
| out.write(result.getBytes(Constants.DEFAULT_CHARSET)); | ||
| } catch (IOException ioe) { | ||
| log.warn("out close failed...", e); | ||
| } |
There was a problem hiding this comment.
how about like this:
byte[] bytes = Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET);
httpExchange.sendResponseHeaders(
200,
bytes.length
);
try (OutputStream out = httpExchange.getResponseBody()) {
out.write(bytes);
} catch (IOException ioe) {
log.warn("out close failed...", e);
}
There was a problem hiding this comment.
@mxsm Done! Have a look, please
mxsm
reviewed
May 10, 2023
Comment on lines
88
to
91
| httpExchange.sendResponseHeaders( | ||
| 200, | ||
| Objects.requireNonNull(result).getBytes(Constants.DEFAULT_CHARSET).length | ||
| ); |
There was a problem hiding this comment.
It needs to be modified here as well.
|
@PickBas Please fix the conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3010.
Modifications
Used try-with-resources for OutputStream
Documentation