Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3897]Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer. #3898

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

pandaapo
Copy link
Member

Fixes #3897.

Motivation

See "Enhancement Request" in issue.

Modifications

See "Describe the solution you'd like" in issue.

Documentation

  • Does this pull request introduce a new feature? no

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #3898 (2a82260) into master (0ce8d57) will decrease coverage by 0.01%.
The diff coverage is 2.94%.

❗ Current head 2a82260 differs from pull request most recent head b0615f0. Consider uploading reports for the commit b0615f0 to get more accurate results

@@             Coverage Diff              @@
##             master    #3898      +/-   ##
============================================
- Coverage     14.24%   14.23%   -0.01%     
+ Complexity     1320     1317       -3     
============================================
  Files           579      578       -1     
  Lines         28967    28949      -18     
  Branches       2802     2801       -1     
============================================
- Hits           4125     4121       -4     
+ Misses        24450    24438      -12     
+ Partials        392      390       -2     
Impacted Files Coverage Δ
...col/http/body/message/PushMessageResponseBody.java 0.00% <0.00%> (ø)
...ol/http/body/message/ReplyMessageResponseBody.java 0.00% <0.00%> (ø)
...ttp/body/message/SendMessageBatchResponseBody.java 0.00% <0.00%> (ø)
...p/body/message/SendMessageBatchV2ResponseBody.java 0.00% <0.00%> (ø)
...col/http/body/message/SendMessageResponseBody.java 0.00% <0.00%> (ø)
...ventmesh/storage/rocketmq/admin/RocketMQAdmin.java 0.00% <0.00%> (ø)
...h/storage/rocketmq/admin/RocketMQAdminAdaptor.java 0.00% <ø> (ø)
...mesh/storage/standalone/admin/StandaloneAdmin.java 96.77% <100.00%> (+4.46%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xwm1992 xwm1992 merged commit d374551 into apache:master Jun 6, 2023
7 checks passed
kyooosukedn pushed a commit to kyooosukedn/eventmesh that referenced this pull request Jun 6, 2023
…RmqAdmin can be more clearer. (apache#3898)

* Modify Admin's hierarchy.

* Fix CI error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Admin, RocketMQAdmin, StandaloneAdmin and AbstractRmqAdmin can be more clearer.
3 participants