[ISSUE #4138] Add Unit Test for UrlMappingPattern

[Pil0tXia]

Fixes #4138 .

Motivation

The TO-DO mark said that "It is better using Mockito not PowerMockito", so I used Mockito. Although there are private method/field to test in the compile() method of UrlMappingPattern.

Modifications

Use reflections to access private method and field, then write regular expressions.

The Test case passed.

Documentation

• Does this pull request introduce a new feature? (no)
• If yes, how is the feature documented? (not applicable)
• If a feature is not applicable for documentation, explain why?
• If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

[pandaapo]

It's OK for me after you remove the old comment // Verify that the compiledUrlMappingPattern field is updated.

[Pil0tXia]

It's OK for me after you remove the old comment // Verify that the compiledUrlMappingPattern field is updated.

Of course, I have committed the changes.

I have a slight confusion in that although the assertNotNull() method does not verify that the compiledUrlMappingPattern matches the mockedPattern as the assertEquals() method did before, it still ensures that the compiledUrlMappingPattern has been updated by not being null.

Could you kindly enlighten me on the reasons behind your thoughts, if you don't mind?

[pandaapo]

In my opinion, TestUrlMappingPattern. compiledUrlMappingPatternField is like a basic or goal, without the need for additional explanation. Additionally, I was also influenced by your previous code (which did update the compiledUrlMappingPatternField in this method).

But your reply reminded me that we can also consider TestUrlMappingPattern. compiledUrlMappingPatternField as part of the testing logic, rather than just a goal. Under this, that comment was actually OK.

[Pil0tXia]

Thank you for your guidance! I agree with your viewpoint. I have reinstated this line of comment, and I would appreciate it if you could kindly approve it when you have a moment.

[pandaapo]

LGTM. CC @xwm1992 @qqeasonchen

[mxsm]

@Pil0tXia CI not pass, pls check it

[Pil0tXia]

@mxsm Hello! I have pulled the latest code from master to fix compile error and made modifications accordingly. 😉

[mxsm]

LGTM

[Pil0tXia]

PTAL😊 @xwm1992

[Pil0tXia]

@lrhkobe PTAL😉