Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4290] queryWebHookConfigByManufacturer endpoint causes NPE and unable to response #4291

Merged
merged 1 commit into from Jul 27, 2023

Conversation

Pil0tXia
Copy link
Member

Fixes #4290.

Motivation

  1. Can not get webHookConfig from node because there is no webHookConfig in node.

  2. pageSize and pageNum are required, but they are missing from the document.

image

image

image

Modifications

Fix code and document:

image

image

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4291 (332268e) into master (c18ef05) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 332268e differs from pull request most recent head b963cc9. Consider uploading reports for the commit b963cc9 to get more accurate results

@@            Coverage Diff            @@
##             master    #4291   +/-   ##
=========================================
  Coverage     16.87%   16.87%           
  Complexity     1426     1426           
=========================================
  Files           593      593           
  Lines         26068    26068           
  Branches       2396     2396           
=========================================
  Hits           4398     4398           
  Misses        21229    21229           
  Partials        441      441           
Files Changed Coverage Δ
...ndler/QueryWebHookConfigByManufacturerHandler.java 28.57% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pandaapo
pandaapo previously approved these changes Jul 26, 2023
@pandaapo pandaapo dismissed their stale review July 26, 2023 23:01

I have a new question.

@pandaapo
Copy link
Contributor

I am confused how the field cloudEventIdGenerateMode value is generated after JsonUtils.parseObject(node.toString(), WebHookConfig.class).

@Pil0tXia
Copy link
Member Author

Pil0tXia commented Jul 27, 2023

@pandaapo This field has a default value in WebHookConfig constructor~

image

@Pil0tXia Pil0tXia requested a review from pandaapo July 27, 2023 06:58
@pandaapo pandaapo merged commit 4e8505b into apache:master Jul 27, 2023
7 checks passed
@Pil0tXia Pil0tXia deleted the pil0txia_bug_4290 branch January 4, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] queryWebHookConfigByManufacturer endpoint causes NPE and unable to response
4 participants