[ISSUE #4454] Support File Sink Connector #4455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4455 +/- ##
============================================
- Coverage 16.95% 15.94% -1.01%
- Complexity 1458 1476 +18
============================================
Files 619 689 +70
Lines 25740 27525 +1785
Branches 2414 2568 +154
============================================
+ Hits 4365 4390 +25
- Misses 20936 22686 +1750
- Partials 439 449 +10
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Pil0tXia
reviewed
Sep 21, 2023
Comment on lines
86
to
96
| @Override | ||
| public void start() throws Exception { | ||
| if (fileName == null || fileName.length() == 0 || filePath == null || filePath.length() == 0) { | ||
| this.outputStream = System.out; | ||
| } else { | ||
| this.outputStream = | ||
| new PrintStream(Files.newOutputStream(Paths.get(filePath + fileName), StandardOpenOption.CREATE, StandardOpenOption.APPEND), | ||
| false, | ||
| StandardCharsets.UTF_8.name()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Is it better to have a extra line break between L93 and L94?
pandaapo
reviewed
Sep 22, 2023
...file/src/main/java/org/apache/eventmesh/connector/file/sink/connector/FileSinkConnector.java
Show resolved
Hide resolved
pandaapo
approved these changes
Sep 22, 2023
qqeasonchen
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4454 .
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
Modifications
Describe the modifications you've done.
Documentation