Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EventMeshTcp2Client.java #4465

Closed
wants to merge 3 commits into from

Conversation

Monika-Sivakumar-3
Copy link
Contributor

Make anonymous inner class a lambda[EventMeshTcp2Client]

Fixes #3399 .

Motivation

Make anonymous inner class a lambda[EventMeshTcp2Client]

Modifications

Make anonymous inner class a lambda

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Copy link
Member

@Pil0tXia Pil0tXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to EventMesh community. You haven't finished all the works mentioned in the issue. You may turn this PR into a draft and then mark it as requesting for review after it is completed.

By the way, please revise your article title according to the standard format.

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monika-Sivakumar-3 Please fix code style

Copy link
Member

@mxsm mxsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Monika-Sivakumar-3 Please run checkstyleMain with IDEA
image
find the code style error and fix it.

@xwm1992
Copy link
Contributor

xwm1992 commented Oct 26, 2023

For there is no response, I'll close this pr.

@xwm1992 xwm1992 closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Make this anonymous inner class a lambda[EventMeshTcp2Client]
4 participants