[ISSUE#4515] Add test case for ProtocolPluginFactory. #4516
Conversation
| Field modifiersField = Field.class.getDeclaredField("modifiers"); | ||
| modifiersField.setAccessible(true); | ||
| modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL); | ||
| field.set(null, mockProtocolAdaptorMap); |
There was a problem hiding this comment.
After you modify the value of the private static final property of ProtocolPluginFactory in this way, should you eventually change the value back to the original value? If not, will it affect the normal use of this attribute?
你这样修改了ProtocolPluginFactory类的private static final属性值以后，最终是否应该再将属性值改回原值？否则是不是就影响了该属性的正常使用？
There was a problem hiding this comment.
Although it does not affect normal use, I handled this with @AfterEach.
There was a problem hiding this comment.
You still haven't fixed the issue I mentioned in your new submission. After you changed the final attribute value to mockProtocolAdaptorMap, it ultimately did not change back to its original value. Affects normal use.
你在新的提交中，并没有修复我说的问题。该final属性值被改成mockProtocolAdaptorMap后，最终没有改回原值。影响正常使用。
| public void testGetProtocolAdaptorWhenMapNotEmpty() { | ||
| ProtocolAdaptor<ProtocolTransportObject> adaptor = ProtocolPluginFactory.getProtocolAdaptor(PROTOCOL_TYPE_NAME); | ||
| Assertions.assertEquals(adaptor.getClass(), MockProtocolAdaptorImpl.class); | ||
| } |
There was a problem hiding this comment.
What do you mean by 'MapNotEmpty' in this test? And what does the other 'BothEmpty' mean?
这个测试你所说的‘MapNotEmpty’是指什么？以及另一个的‘BothEmpty’是指什么？
There was a problem hiding this comment.
It has been changed to a clearer name.
There was a problem hiding this comment.
Can the testing logic of this method be merged to the beginning of testGetProtocolAdaptorWithAdaptorMap() without the need to define a separate method?
这个方法的测试逻辑，是不是可以合并到testGetProtocolAdaptorWithAdaptorMap()最前面，而没必要单独定义一个方法？
Codecov Report
@@ Coverage Diff @@
## master #4516 +/- ##
============================================
- Coverage 15.97% 15.90% -0.07%
+ Complexity 1549 1545 -4
============================================
Files 727 730 +3
Lines 28872 28891 +19
Branches 2744 2743 -1
============================================
- Hits 4613 4596 -17
- Misses 23776 23813 +37
+ Partials 483 482 -1
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...-api/src/test/resources/META-INF/eventmesh/org.apache.eventmesh.protocol.api.ProtocolAdaptor
Show resolved
Hide resolved
...-protocol-api/src/test/java/org/apache/eventmesh/protocol/api/ProtocolPluginFactoryTest.java
Outdated
Show resolved
Hide resolved
Fixes #4515
Modifications
Add test case for ProtocolPluginFactory.