Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4596]Fix SourceWorker#convertRecordToEvent method converts ConnectRecord to CloudEvent throw NPE #4597

Merged
merged 2 commits into from Dec 3, 2023

Conversation

mxsm
Copy link
Member

@mxsm mxsm commented Dec 2, 2023

…nnectRecord to CloudEvent throw NPE

Fixes #4596

Motivation

Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.

  • Fix SourceWorker#convertRecordToEvent method converts ConnectRecord to CloudEvent throw NPE

Modifications

Describe the modifications you've done.

  • Fix SourceWorker#convertRecordToEvent method converts ConnectRecord to CloudEvent throw NPE

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

pandaapo
pandaapo previously approved these changes Dec 2, 2023
@hhuang1231
Copy link
Contributor

org.apache.eventmesh.openconnect.util.CloudEventUtil has two method will involve conversion between CloudEvent and ConnectRecord, is there a similar problem?

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5998926) 16.79% compared to head (3a9f192) 16.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4597   +/-   ##
=========================================
  Coverage     16.79%   16.79%           
  Complexity     1677     1677           
=========================================
  Files           782      782           
  Lines         29317    29317           
  Branches       2532     2532           
=========================================
  Hits           4924     4924           
  Misses        23933    23933           
  Partials        460      460           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mxsm
Copy link
Member Author

mxsm commented Dec 2, 2023

org.apache.eventmesh.openconnect.util.CloudEventUtil has two method will involve conversion between CloudEvent and ConnectRecord, is there a similar problem?

Yes I will fix it

@mxsm
Copy link
Member Author

mxsm commented Dec 2, 2023

ping @hhuang1231

@xwm1992 xwm1992 merged commit 2a46b82 into apache:master Dec 3, 2023
13 checks passed
@mxsm mxsm deleted the bug-mxsm-4596 branch December 3, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] SourceWorker#convertRecordToEvent method converts ConnectRecord to CloudEvent throw NPE
4 participants