This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-1964 Should delete temporary JKS file after IT tests for credential provider alias #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial provider alias
| @@ -67,6 +67,12 @@ public void testResolveAlias() throws Exception { | |||
| properties.resolveAlias(); | |||
| Assert.assertEquals(properties.getProperty(PROPERTY_1), PASSWORD_1); | |||
| Assert.assertEquals(properties.getProperty(PROPERTY_2), PASSWORD_2); | |||
|
|
|||
| // delete temporary jks files | |||
There was a problem hiding this comment.
Can you please add it as @afterclass to ensure these files are deleted even if there are test failures
There was a problem hiding this comment.
Thanks for pointing this out, @bvellanki . Added to AfterClass.
|
+1 |
| @AfterClass | ||
| public void tearDown() throws Exception { | ||
| // delete temporary jks files | ||
| File credDir = new File("."); |
There was a problem hiding this comment.
Can we define credDir as public static final String CRED_DIR so that it can be reused in tearDown and testResolveAlias? Thanks!
|
+1, will commit. |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…ntial provider alias Author: yzheng-hortonworks <yzheng@hortonworks.com> Reviewers: "Sowmya Ramesh <sramesh@hortonworks.com>, Balu Vellanki <balu@apache.org>" Closes apache#146 from yzheng-hortonworks/FALCON-1964
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.