This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-1974 Cluster update : Allow superuser to update bundle/coord of dependent entities #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f dependent entities
| //Set end times for old coords | ||
| updateCoords(clusterName, oldBundle, EntityUtil.getParallel(oldEntity), effectiveTime, newEntity); | ||
| //schedule new entity | ||
| String newJobId = scheduleForUpdate(newEntity, cluster, effectiveTime, user); |
There was a problem hiding this comment.
The function scheduleForUpdate also performs user switch (current user -> user -> current user). However, since you already switch the user before calling scheduleForUpdate, the switch is no longer needed in scheduleForUpdate. Better to remove the "user" argument and user switch in scheduleForUpdate, as this function is only being used in updateInternal.
There was a problem hiding this comment.
Good catch @yzheng-hortonworks , I will make the necessary update.
…f dependent entities
|
+1 |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…f dependent entities Author: bvellanki <bvellanki@hortonworks.com> Reviewers: "Ying Zheng <yzheng@hortonworks.com>" Closes apache#151 from bvellanki/FALCON-1974
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.