This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2038 When all Optional input instances are missing, partition should not be suffixed. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not suffix partition
| @@ -168,6 +168,8 @@ public void testDataInOptional(String expuris, String partition, String doneFlag | |||
| "*/US", "_DONE", }, | |||
| // With availability flag. All instances missing | |||
| {"hdfs://localhost:8020/projects/falcon/staging/EMPTY_DIR_DONT_DELETE", "null", "_FINISH"}, | |||
| // With availability flag and partitions. All instances missing | |||
| {"hdfs://localhost:8020/projects/falcon/staging/EMPTY_DIR_DONT_DELETE", "*", "_FINISH"}, | |||
There was a problem hiding this comment.
what in case of multi level partitions?
There was a problem hiding this comment.
Code path is the same, whether there is one partition or multi-level. Whether I use * or //* in UT, the result will be same.
|
+1 |
1 similar comment
|
👍 |
|
Looks good. +1 . |
asfgit
pushed a commit
that referenced
this pull request
Jun 21, 2016
…should not be suffixed. Updated code and UT. Author: Pallavi Rao <pallavi.rao@inmobi.com> Reviewers: @PraveenAdlakha, @sandeepSamudrala, @peeyushb Closes #191 from pallavi-rao/2038 (cherry picked from commit 3abefcc) Signed-off-by: Pallavi Rao <pallavi.rao@inmobi.com>
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…should not be suffixed. Updated code and UT. Author: Pallavi Rao <pallavi.rao@inmobi.com> Reviewers: @PraveenAdlakha, @sandeepSamudrala, @peeyushb Closes apache#191 from pallavi-rao/2038
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code and UT.