This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2044 Persist Process stats in db #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pallavi-rao @bvellanki @sowmyaramesh Can any one of you please review this ? Its pending for quiet some time now. |
| /** | ||
| * FalconDB NotificationPlugin. | ||
| */ | ||
| public class FalconDBNotificationPlugin implements MonitoringPlugin { |
There was a problem hiding this comment.
nit: FalconDBNotificationPlugin doesn't convey much about the functionality of this plugin. Do you think it will be better to rename it to something like "ProcessExecutionStatsPlugin"?
|
@PraveenAdlakha Can you please rebase and run jenkins again(close and open the pull request)? |
PraveenAdlakha
force-pushed
the
2044
branch
2 times, most recently
from
7452096
to
b226577
Compare
|
👍 Will commit shortly |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
Author: Praveen Adlakha <adlakha.praveen@gmail.com> Reviewers: Ajay Yadava <ajayyadava@apache.org> Closes apache#196 from PraveenAdlakha/2044
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.