FALCON-2080 Exceptions in the log #227
Conversation
| @@ -442,7 +443,11 @@ private boolean checkEntityInstanceAvailability(String entityName, String cluste | |||
| String entityType) throws | |||
| FalconException { | |||
| Entity entity = EntityUtil.getEntity(entityType, entityName); | |||
|
|
|||
| if (entity.getACL().getOwner() != null && !entity.getACL().getOwner().isEmpty()) { | |||
There was a problem hiding this comment.
It might be better to have a method like OozieWorkflowEngine::switchUser() and switch back after the checkInstance command is run.
There was a problem hiding this comment.
StringUtils.isNotBlank() can be used, instead of checking for null and empty condition for owner String value.
|
Agree with @bvellanki. I too think it is better to use the switchUser in OozieWorkflowEngine like it is done in other methods of OWE. |
PraveenAdlakha
force-pushed
the
2080
branch
3 times, most recently
from
21c823b
to
66e64fd
Compare
| Entity entity = EntityUtil.getEntity(entityType, entityName); | ||
|
|
||
| autheticateUser(entity); |
There was a problem hiding this comment.
Nit: Typo : authenticate (it says autheticate)
|
Hi All, As we will be running the code in multithreaded mode thats why not removed the static method which was there in earlier commit. Thanks |
|
+1. Will merge shortly unless anyone has further comments |
|
+1. Looks good. |
Author: Praveen Adlakha <adlakha.praveen@gmail.com> Reviewers: @pallavi-rao, @peeyushb Closes apache#227 from PraveenAdlakha/2080 and squashes the following commits: 2ac9ead [Praveen Adlakha] comments addressed 458a669 [Praveen Adlakha] comments addressed ed6f7fe [Praveen Adlakha] FALCON-2080 Exceptions in the log
No description provided.