This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2120 falcon-regression build is failing because of CLI and hiv… #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 from my end. |
|
👍 |
|
Thanks @PraveenAdlakha .
|
|
We no longer need the pentaho dependency, hence can go away with it. @PraveenAdlakha please remove the cli dependency as @muraliramasami will be taking care of it. |
|
@pragya-mittal I just verified we still need falcon-cli as its needed in Bundle.java. |
|
@muraliramasami has already added the dependency as part of #275. Please check. |
|
@pragya-mittal have removed it...please check now. |
|
+1. Will merge the pull request tomorrow if there are no further comments. |
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
…e changes Author: Praveen Adlakha <adlakha.praveen@gmail.com> Author: praveen.adlakha <adlakha.praveen@gmail.com> Reviewers: "Pragya Mittal <mittal.pragya23@gmail.com>" Closes apache#271 from PraveenAdlakha/2120 and squashes the following commits: ee198d6 [praveen.adlakha] cli dependency removed 3762757 [Praveen Adlakha] FALCON-2120 falcon-regression build is failing because of CLI and hive changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e changes