This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2195 Extension Job Details changes #315
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavi-rao
suggested changes
Dec 7, 2016
@@ -1029,6 +1030,12 @@ public String getExtensionDetail(final String extensionName) { | |||
return getResponse(String.class, getExtensionDetailResponse(extensionName)); | |||
} | |||
|
|||
public String getExtensionJobDetails(final String jobName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be part of AbstractClient and have FalconUnitClient also implement it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the respective changes and updated the falcon unit and test falcon unit tests to validate the same.
…est falcon unit to test the same
@sandeepSamudrala, please address the merge conflicts. |
pallavi-rao
approved these changes
Dec 12, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
Author: sandeep <sandysmdl@gmail.com> Reviewers: @pallavi-rao Closes apache#315 from sandeepSamudrala/FALCON-2195 and squashes the following commits: 350957f [sandeep] FALCON-2195 Rebased my patch to resolve merge conflicts 5f7e209 [sandeep] FALCON-2195 Added getExtensionJobDetails to falcon unit and updated test falcon unit to test the same 8f209ea [sandeep] FALCON-2195 Extension Job Details changes dc9090e [sandeep] Merge branch 'master' of https://github.com/apache/falcon into FALCON-2195 f96a084 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 9cf36e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon bbca081 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 48f6afa [sandeep] Merge branch 'master' of https://github.com/apache/falcon 250cc46 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d0393e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon a178805 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d6dc8bf [sandeep] Merge branch 'master' of https://github.com/apache/falcon 1bb8d3c [sandeep] Merge branch 'master' of https://github.com/apache/falcon c065566 [sandeep] reverting last line changes made 1a4dcd2 [sandeep] rebased and resolved the conflicts from master 271318b [sandeep] FALCON-2097. Adding UT to the new method for getting next instance time with Delay. a94d4fe [sandeep] rebasing from master 9e68a57 [sandeep] FALCON-298. Feed update with replication delay creates holes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.