Skip to content
This repository has been archived by the owner on Apr 4, 2021. It is now read-only.

FALCON-1821 Update git pull merge script to accept and update JIRA type #33

Closed
wants to merge 1 commit into from

Conversation

pallavi-rao
Copy link

No description provided.

>>> standardize_jira_ref("[FALCON-1009] id in brackets")
'FALCON-1009 id in brackets'
"""
# """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to prefix # here.

@ajayyadava
Copy link
Contributor

I think this information is already there in JIRA and should be fetched from JIRA. Maintaining same information in two places can cause discrepancies. Let's keep JIRA as source of truth and fetch information from there.

@pallavi-rao
Copy link
Author

The reason this is added is because of the following reasons:

  1. JIRA Type may not directly map to our categorization, for example, backward incompatible changes. Sub-Task can be a "New feature". So, this lets the committer override the default categorization, if required.
  2. It is just part of commit message similar to title, contributor (author) that also can be retrieved from JIRA. It is just making it available in one place as git log.

@ajayyadava
Copy link
Contributor

In view of FALCON-2063 I believe this change should also not be required.

@ajayyadava
Copy link
Contributor

As noticed in my earlier comment, this change is not required any longer as we have started using Apache Yetus. I will be closing this pull request as part of the clean up.

@asfgit asfgit closed this in 8032118 Sep 3, 2016
sandeepSamudrala pushed a commit to sandeepSamudrala/falcon that referenced this pull request Oct 26, 2016
FALCON-729 When feed from multiple colos are replicated, the colo fo…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants