FALCON-2260 Enhance extension List api to support for user extensions #343
Conversation
… submission and colo addition to schedule command
…endant on the extension
| @@ -80,5 +80,6 @@ private PersistenceConstants(){ | |||
| public static final String GET_ALL_EXTENSION_JOBS = "GET_ALL_EXTENSION_JOBS"; | |||
| public static final String DELETE_EXTENSION_JOB = "DELETE_EXTENSION_JOB"; | |||
| public static final String GET_EXTENSION_JOB = "GET_EXTENSION_JOB"; | |||
| public static final String GET_JOBS_FOR_AN_EXTENSION = "GET_JOBS_FOR_AN_EXTENSION"; | |||
There was a problem hiding this comment.
The variable name implies it will return the job name only.Better return the job name rather than reiterating over the result again to get jobname.
There was a problem hiding this comment.
Was thinking the same initially, but then to get all details I can always create a new query. I have made the changes accordingly.
| @@ -100,8 +100,6 @@ public void testTrustedExtensionJob() throws Exception { | |||
| // validate job list results | |||
| ExtensionJobList jobs = context.getExtensionJobs("hdfs-mirroring", null, null, null, null, null); | |||
| Assert.assertEquals(jobs.numJobs, 2); | |||
| Assert.assertEquals(jobs.job.get(0).jobName, JOB_NAME_1); | |||
There was a problem hiding this comment.
Can we unable this test case and see if test cases are running correctly.Right now the test cases have been disabled.
@test (enabled = false)
There was a problem hiding this comment.
This Test still doesn't seem to be working.
| @@ -132,6 +132,18 @@ public ExtensionBean getDetail(String extensionName) { | |||
| } | |||
| } | |||
|
|
|||
| public List<ExtensionJobsBean> getJobsForAnExtension(String extensionName) { | |||
There was a problem hiding this comment.
Please add unit test for this.
There was a problem hiding this comment.
Ack. Added.
|
I have no further comments. Regarding, ExtensionManagerIT, I think it would be a good idea to park a JIRA to ensure trusted extension is not regressed. Will merge once @PraveenAdlakha approves. |
|
Just one comment, the description of the list option needs to be changed: |
|
@pallavi-rao : I had modified the documentation accordingly and I created the following jira to address the test case. |
|
Thanks @sandeepSamudrala. @PraveenAdlakha, please re-review. |
|
+1 |
Author: sandeep <sandysmdl@gmail.com> Reviewers: @PraveenAdlakha Closes apache#343 from sandeepSamudrala/FALCON-2260 and squashes the following commits: 5d9c151 [sandeep] Incorporated review comments 410f6a7 [sandeep] Incorporated review comments 7609139 [sandeep] Merge branch 'master' of https://github.com/apache/falcon into FALCON-2260 8f2a8d4 [sandeep] Corrected error messages c949059 [sandeep] FALCON-2260 Enhance extension List api to support for user extensions d317d3d [sandeep] Fixed tests 6617993 [sandeep] Incorporated review comments 46ad617 [sandeep] Incorporated review comments c1189be [sandeep] Incorporated review comments a70f5a9 [sandeep] FALCON-2259 Unregister an extension only if no extension jobs are dependant on the extension 7e16263 [sandeep] Merge branch 'master' of https://github.com/apache/falcon a234d94 [sandeep] FALCON-2231 Incoporated review comments and small fixes for duplicate submission and colo addition to schedule command 26e3350 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 73fbf75 [sandeep] Merge branch 'master' of https://github.com/apache/falcon cc28658 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 089b10d [sandeep] Merge branch 'master' of https://github.com/apache/falcon 456d4ee [sandeep] Merge branch 'master' of https://github.com/apache/falcon 0cf9af6 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 4a2e23e [sandeep] Merge branch 'master' of https://github.com/apache/falcon b1546ed [sandeep] Merge branch 'master' of https://github.com/apache/falcon 0a433fb [sandeep] Merge branch 'master' of https://github.com/apache/falcon 194f36a [sandeep] Merge branch 'master' of https://github.com/apache/falcon e0ad358 [sandeep] Merge branch 'master' of https://github.com/apache/falcon f96a084 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 9cf36e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon bbca081 [sandeep] Merge branch 'master' of https://github.com/apache/falcon 48f6afa [sandeep] Merge branch 'master' of https://github.com/apache/falcon 250cc46 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d0393e9 [sandeep] Merge branch 'master' of https://github.com/apache/falcon a178805 [sandeep] Merge branch 'master' of https://github.com/apache/falcon d6dc8bf [sandeep] Merge branch 'master' of https://github.com/apache/falcon 1bb8d3c [sandeep] Merge branch 'master' of https://github.com/apache/falcon c065566 [sandeep] reverting last line changes made 1a4dcd2 [sandeep] rebased and resolved the conflicts from master 271318b [sandeep] FALCON-2097. Adding UT to the new method for getting next instance time with Delay. a94d4fe [sandeep] rebasing from master 9e68a57 [sandeep] FALCON-298. Feed update with replication delay creates holes
No description provided.