This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2247 include status of entities in getDetailExtensionJobs #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (String feed : jobsBean.getFeeds()) { | ||
| try { | ||
| EntityUtil.getEntity(EntityType.FEED, feed); | ||
| } catch (EntityNotRegisteredException e) { |
There was a problem hiding this comment.
only type is changed in these 2 segments. Extract a method for the same
sandeepSamudrala
approved these changes
Jan 23, 2017
pallavi-rao
suggested changes
Jan 24, 2017
| try { | ||
| EntityUtil.getEntity(type, entity); | ||
| } catch (EntityNotRegisteredException e) { | ||
| entityObject.put(entity, ENTITY_NOT_EXISTS_STATUS); |
There was a problem hiding this comment.
By JSON standards, the keys are usually constant strings. This should be { "name" : "abc, "status" : "EXISTS"}
This makes it easy to consume programmatically also.
There was a problem hiding this comment.
valid point. Have made the changes.
sandeepSamudrala
approved these changes
Jan 24, 2017
pallavi-rao
pushed a commit
to pallavi-rao/falcon
that referenced
this pull request
Feb 16, 2018
Author: Pracheer Agarwal <pracheer.agarwal@inmobi.com> Author: Pracheer Agarwal <pracheeragarwal@gmail.com> Author: Pracheer Agarwal <pr@im2216-x0.corp.inmobi.com> Author: sandeep <sandysmdl@gmail.com> Reviewers: @sandeepSamudrala, @pallavi-rao Closes apache#345 from PracheerAgarwal/FALCON-2247 and squashes the following commits: c57efa2 [sandeep] FALCON-2247 review commits changes 56492e7 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon into FALCON-2247 76215d7 [Pracheer Agarwal] changes for review comments c38c51b [Pracheer Agarwal] indentation changes 2ad4ce7 [Pracheer Agarwal] bug fixes 5d01f9c [Pracheer Agarwal] FALCON-2247 include status of entities in getDetailExtensionJobs 778c579 [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e39808d [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a932633 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon fda3b28 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon a93d71a [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon e3728d5 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 066c8e2 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon b20f044 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 7f572a1 [Pracheer Agarwal] Merge branch 'master' of https://github.com/apache/falcon 46042fd [Pracheer Agarwal] Merge branch 'master' of https://github.com/PracheerAgarwal/falcon daa3ffc [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions 622cae4 [Pracheer Agarwal] FALCON-2225 extension owner added for trusted extensions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.