This repository has been archived by the owner on Apr 4, 2021. It is now read-only.
FALCON-2285 Ignored instances are not being abled to be killed #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… submission and colo addition to schedule command
pallavi-rao
suggested changes
Mar 10, 2017
@@ -949,7 +949,8 @@ private void performAction(String cluster, JobAction action, CoordinatorAction c | |||
status = Status.KILLED.name(); | |||
break; | |||
} | |||
if (!WF_KILL_PRECOND.contains(jobInfo.getStatus())) { | |||
if (!WF_KILL_PRECOND.contains(jobInfo.getStatus()) && | |||
jobInfo.getStatus().name().equalsIgnoreCase(Status.IGNORED.name())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you rather add IGNORED to WF_KILL_PRECOND, instead?
Closing this pull request as this is more an issue from oozie as the instance status not being changed to READY from KILLED state upon rerun until as there is a concurrency limit. This has to be fixed at the oozie end. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.