FELIX-6614 WebConsole configMgr saves an empty value in list properites

[sagarmiglani]

This pull request addresses the issue of an empty value being saved when a list property has no value (FELIX-6614). The proposed solution is to filter out the request query parameters that have empty values.

[kwin]

maybe one could reuse the same code here and in createSpan(...) to reduce duplication.

[cziegeler]

The new "add" button is now displayed for every list property. Shouldn't it only be displayed if there is no value yet?

[kwin]

I think the best UX would be

• one delete button per item
• one add button per list
• possibility to reorder (maybe leveraging https://jqueryui.com/sortable/)

The "+" per item is very uncommon and is IMHO not needed if there is a possibility to reorder.

[cziegeler]

Let's not put too many changes into this single issue. The most important part is to avoid saving the empty value. So I suggest, we keep the add/delete buttons after each field. And if there is no value yet, only display the add button

[sagarmiglani]

The new "add" button is now displayed for every list property. Shouldn't it only be displayed if there is no value yet?

@cziegeler Thank you for reviewing, I made this decision based on our current implementation, which includes a '+' button next to each field. This button enables users to add a new empty field below it, granting them the ability to add values at any index, excluding the first one. By keeping the '+' button "at top" visible at all times, we provide users with the option to add new values at the first index as well. However, if you strongly recommend against displaying the top '+' button at all times, I am open to making changes accordingly.

[kwin]

I think this comment referred only to the topmost add icon (not bound to an item, compare with the screenshot).

[sagarmiglani]

@kwin I am also referring to the topmost add icon.

Here is the comparison:

Scenario	Present scenario	Proposed solution
1	When there is not value in array, an empty field is present along with "+" and "-" button	When there is no value in array, only "+" button is visible (which is visible all the time)
2	User can add a new row by clicking on "+" button and remove the row by clicking on "-"	User can add a new row by clicking on "+" button and remove the row by clicking on "-"
3	If there are multiple rows, user can add a row in-between by clicking on "+" button. i.e if there are rows 1,2,3; user can add a new row between 2 and 3 by clicking "+" button of row 2	If there are multiple rows, user can add a row in-between by clicking on "+" button. i.e if there are rows 1,2,3; user can add a new row between 2 and 3 by clicking "+" button of row 2
4	User can not add any row at first index, while can add at any other index.	User can add any row at first index by clicking on topmost "+" button
5	If user deletes all rows, there is no option to add a new row	If user deletes all rows, a new row can still be added by clicking on topmost "+" button

[kwin]

@sagarmiglani Thanks for the clarification, makes sense to me. But as I am not a committer you would need @cziegeler's approval and merge.

[cziegeler]

@sagarmiglani Thanks for the comparison. I think the item where we have different opinions is row 4 - while I agree that it would be consistent to allow to add a value to the first row, I think this is a limited use case - in many cases the ordering of the values does not matter. But with the button always there, it takes more screen space than today.
But I'm fine either way. if you think we should go with what you propose, I'm happy to apply the change