Commits on Sep 10, 2020

1. FELIX-6327 - NoSuchElementException when services are removed …

   The tryInvokeBind method needs more safeguards around when the reference
   that just got bound is detected that it got removed.
   
   The previous code always assumed there was at least one other viable
   reference to bind to.  That causes the NoSuchElementException when
   trying to find a fallback reference.  Fixing that exposed another issue
   with the previous code where the state of the DependencyManager is not
   properly restored in two aspects:
   
   1) Even when unbind is not invoked during tryInvokeBind the
   currentRefPair would get set to null when it must remain set to the
   previous value in cases where the invoke bind fails.  A check is needed
   to be sure to only clear the currentRefPair if unbind was successfully
   invoked.
   
   2) After invoking bind/unbind there is a check to see if the reference
   is still viable (not deleted).  This is where the reported problem
   occurs when there is no alternative reference available and a
   NoSuchElementException is thrown.  Avoiding the NoSuchElementException
   and returning from tryInvokeBind would leave the DependencyManager in a
   state where it thinks there is still a binding thread doing work when
   that thread is really done.  Additional checks are needed to ensure we
   always restore the binding thread state of the DepenencyManager on exit
   of tryInvokeBind method.

   

   tjwatson committed Sep 10, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 87f3aff
   • Browse repository at this point

   Copy the full SHA

   87f3aff View commit details

   Browse the repository at this point in the history