[FELIX-6407] SCR Logging Fixes and Improvements #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed Problem with Extended Logging 2. Introduced functionality to disable logging Fixes #FELIX-6407 Signed-off-by: Amit Kumar Mondal <admin@amitinside.com>
|
This corrects a problem after I introduced the logging extension to minimize log output and keep it from being mixed up with the bundle's logging. A patch after my change changed this.bundle to bundle but that then referenced the wrong bundle. Could this be processed ASAP? |
|
@tjwatson Just checking on you if you have had a moment to review this MR. I would really appreciate it. Thanks in advance. |
I put a comment in https://issues.apache.org/jira/browse/FELIX-6407 |
tjwatson
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FELIX-6407