Introduced thread-safety while updating field during deactivation phase #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cziegeler @tjwatson Could you kindly have a look at it? |
|
When the problem occurred what sort of errors/warnings or incorrect behavior did you observe? Any stack trace? [EDIT] - nevermind you put this in https://issues.apache.org/jira/browse/FELIX-6439 |
|
I have added the stacktrace to the JIRA bug report |
tjwatson
reviewed
Jul 21, 2021
scr/src/main/java/org/apache/felix/scr/impl/manager/ComponentContextImpl.java
Outdated
Show resolved
Hide resolved
tjwatson
reviewed
Jul 22, 2021
scr/src/main/java/org/apache/felix/scr/impl/inject/field/FieldHandler.java
Outdated
Show resolved
Hide resolved
The problem occurred when multiple injected services tried to be removed from the component's injection. It is highly likely because of the usage of TreeMap in such concurrent environment. Since TreeMap has never been written to be used in a concurrent environment, we should use ConcurrentSkipListMap instead as all the features of TreeMap have been introduced in ConcurrentSkipListMap and it is very much suitable for concurrent environment. Introduced thread-safety while updating field during deactivation phase
amitjoy
force-pushed
the
bug/FELIX-6439/npe-treemap
branch
from
b873f57
to
cf2cf3c
Compare
amitjoy
changed the title
|
@tjwatson Is it possible to merge this as it can then be part of the next SCR release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem occurred when multiple injected services tried to be removed from the component's injection. It is highly likely because of the usage of
TreeMapin such concurrent environment. SinceTreeMaphas never been written to be used in a concurrent environment, we should useConcurrentSkipListMapinstead as all the features ofTreeMaphave been introduced inConcurrentSkipListMapand it is very much suitable for concurrent environment.