Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Feat: Adds support for all functionalities of a Group. #101

Merged
merged 1 commit into from Jul 11, 2020

Conversation

jawidMuhammadi
Copy link
Contributor

@jawidMuhammadi jawidMuhammadi commented Apr 7, 2020

This PR has been created on top of PR #68 that has been developed by Mr. Saksham Handu in GSOC'2019, and this PR adds support for following functionalities and improvements which were missing in his PR:

  1. Edit and Update group details
  2. Edit or delete group members name
  3. Edit or delete group leaders name
  4. Reopen a group if it has been closed
  5. Activate a group if it is pending
  6. Close a group account
  7. UI refactoring in GroupdDetailsFragment, AddGroupMemberFragment, AddGroupLeaderFragment, and ReviewFragment to provide a better UX/UI experience to users based on Material Design guidelines.
  8. Adds Coroutines Library to call APIs in Background Thread and Handle Errors in a better way which is Google's recommended way.
  9. Refactored the signature of the creating group method to handle network errors.
  • Viewing Group Details and Group Tasks(Reopen, Close, Activate)

group_details_and_task

  • Edit Group Details:

edit_group

  • Add, Edit, and Delete Leaders Name:

add_edit_delete_leader_names

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything.

  • If you have multiple commits please combine them into one commit by squashing them.

:
Feat: Adds support for creating, viewing, editing group details, deleting, editing members and leaders name and tasks of group
@jawidMuhammadi
Copy link
Contributor Author

Dear @therajanmaurya, @awasum Please take a look at this PR.

@therajanmaurya therajanmaurya merged commit 592099e into apache:development Jul 11, 2020
@jawidMuhammadi jawidMuhammadi deleted the groups_edit branch July 15, 2020 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants